Skip to content

Update API for realtime publisher #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Update API for realtime publisher #1830

wants to merge 18 commits into from

Conversation

christophfroehlich
Copy link
Contributor

ros-controls/realtime_tools#323

admittance controller didn't use the try_lock in the RT loop btw.

@christophfroehlich christophfroehlich added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Jul 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.21429% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.14%. Comparing base (42e7ba4) to head (fb4b0bf).

Files with missing lines Patch % Lines
...iff_drive_controller/src/diff_drive_controller.cpp 62.50% 8 Missing and 1 partial ⚠️
tricycle_controller/src/tricycle_controller.cpp 62.50% 8 Missing and 1 partial ⚠️
...llers_library/src/steering_controllers_library.cpp 92.10% 1 Missing and 2 partials ⚠️
..._state_broadcaster/src/joint_state_broadcaster.cpp 93.54% 0 Missing and 2 partials ⚠️
..._drive_controller/src/mecanum_drive_controller.cpp 94.59% 0 Missing and 2 partials ⚠️
...dmittance_controller/src/admittance_controller.cpp 75.00% 0 Missing and 1 partial ⚠️
...roadcaster/src/force_torque_sensor_broadcaster.cpp 75.00% 0 Missing and 1 partial ⚠️
gpio_controllers/src/gpio_command_controller.cpp 92.30% 0 Missing and 1 partial ⚠️
..._sensor_broadcaster/src/gps_sensor_broadcaster.cpp 87.50% 0 Missing and 1 partial ⚠️
...ory_controller/src/joint_trajectory_controller.cpp 96.42% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
- Coverage   85.25%   85.14%   -0.11%     
==========================================
  Files         143      143              
  Lines       13790    13734      -56     
  Branches     1197     1200       +3     
==========================================
- Hits        11756    11694      -62     
+ Misses       1636     1633       -3     
- Partials      398      407       +9
Flag Coverage Δ
unittests 85.14% <88.21%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...r_broadcaster/test/test_imu_sensor_broadcaster.cpp 97.00% <ø> (ø)
...oint_state_broadcaster/joint_state_broadcaster.hpp 100.00% <ø> (ø)
..._broadcaster/test/test_joint_state_broadcaster.cpp 96.93% <100.00%> (ø)
...jectory_controller/joint_trajectory_controller.hpp 50.00% <ø> (ø)
..._controller/test/test_mecanum_drive_controller.cpp 100.00% <100.00%> (ø)
..._controller/test/test_mecanum_drive_controller.hpp 86.66% <ø> (-0.29%) ⬇️
...nclude/tricycle_controller/tricycle_controller.hpp 100.00% <ø> (ø)
...dmittance_controller/src/admittance_controller.cpp 74.55% <75.00%> (-0.54%) ⬇️
...roadcaster/src/force_torque_sensor_broadcaster.cpp 89.68% <75.00%> (-1.43%) ⬇️
gpio_controllers/src/gpio_command_controller.cpp 83.51% <92.30%> (-0.64%) ⬇️
... and 10 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Amronos Amronos mentioned this pull request Jul 26, 2025
Open
@christophfroehlich christophfroehlich mentioned this pull request Jul 26, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar Awaiting requested review from bmagyar

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@erickisos erickisos Awaiting requested review from erickisos

@livanov93 livanov93 Awaiting requested review from livanov93

@mcbed mcbed Awaiting requested review from mcbed

@xguay xguay Awaiting requested review from xguay

@saikishor saikishor Awaiting requested review from saikishor

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport-jazzy Triggers PR backport to ROS 2 jazzy.
Projects
Roadmap / Features
Status: Kilted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@christophfroehlich